Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

[WIP] Expand selection on repeated calls to bracket-matcher:select-inside-brackets#337

Open
winstliu wants to merge 4 commits intomasterfrom
wl-bwinton-expand-selection
Open

[WIP] Expand selection on repeated calls to bracket-matcher:select-inside-brackets#337
winstliu wants to merge 4 commits intomasterfrom
wl-bwinton-expand-selection

Conversation

@winstliu
Copy link
Contributor

@winstliu winstliu commented Dec 11, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This is a re-implementation of #167. On repeated calls to bracket-matcher:select-inside-brackets, the selection should expand to include the pairs themselves and then the next enclosing pair, etc. For example:
(a b (c d e))
(a b (c d e))
(a b (c d e))
(a b (c d e))

TODO:

  • Make it work with tags
  • Specs

Alternate Designs

I suppose a new command could be added, bracket-matcher:expand-current-selection. However, that seems quite clunky.

Benefits

Ability to easily expand the current selection.

Possible Drawbacks

The command name (select-inside-brackets) is now a bit misleading since it will also expand the current selection.

Applicable Issues

Supersedes and closes #167
Fixes #74

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand bracket selection as select-inside-brackets is triggered

2 participants